Instrumentation support for dataloader by bbakerman · Pull Request #175

Instrumentation support for dataloader by bbakerman · Pull Request #175 · graphql-java/java-dataloader

Conversation

This is now complete and ready to be merged.

DataLoaderOptions is now immutable and hence some teaks t the original code had been done

…edDataLoaderInstrumentation

…erInstrumentationContext

		}

		DataLoader<K, V> build() {
		public DataLoader<K, V> build() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed in previous PR

Hey Brad,

I have used this PR in my local setup to implement spring-projects/spring-graphql#1034 and it works really well. I can now instrument dataloader calls without conflating them with regular data fetcher calls:

So, all good from my perspective and ready to adopt this feature when it's out.
Thanks for the awesome work!

…port

# Conflicts:
#	src/main/java/org/dataloader/DataLoaderOptions.java