Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chaining is good however even with this change you can still write

DataLoaderOptions options = DataLoaderOptions.newOptions()
                .withMaxBatchSize(5);
        
        options.withBatchingEnabled(false);

Which is breaking

I feel like instead if you remove newOptions() and swap to static the IDE will hint the bad pattern of static methods on the instance, no longer recommend chaining on the concrete instance and hint people towards chaining only on the builder

IDE hinting to not use the static methods on the instance which would break the behavior

IDE not suggesting chaining of the static methods

(It will allow you to explicitly type it out but won't suggest it and will warn if you do) This code is technically valid but i feel like we want to push people to the Builder since it exists now

Push people towards proper builder pattern