Fix: tp size wouldn't read from env by S1ro1 · Pull Request #3716 · huggingface/accelerate

Conversation

@S1ro1

With change in #3700 where we default to None, passing 1 as tp_size would result in env vars not being read.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

winglian

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. thanks!

SunMarc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! nice catch