Comparing desktop:development...hydraulic-software:conveyorize · desktop/desktop
Commits on Jan 2, 2023
-
1. Add a GitHub Actions CI job to compile the JS. The GitHub Desktop build system does a lot of customizations based on what the current OS is. Although it could be fixed to support cross-building, it's easier to just use Actions to build the out/ directory on each target platform. This requires some small adjustments to build.ts so we can produce the input files without running Electron Packager. 2. Add conveyor.conf 3. Update the README 4. Adjust the startup code to be more flexible about URL parsing. This is needed because the way URL open requests are received with Conveyor is different.
-
Conveyorize: Delete code that isn't needed anymore.
Justifications: - Update banners and in-app update control UI is irrelevant on Windows where the app may be updated in the background even when it's not running. - Likewise for macOS where Sparkle 2 will provide in-app update UI for us at startup if a new update is available. - Squirrel install/uninstall events aren't needed or received anymore. - If there's a desire for an update channel that always updates synchronously, Conveyor's aggressive mode updates can be used for that and will provide update UI already. NB: We lose the installation of the github.bat file with these deletions. It will return in a future update.