fix(ci): make unique and improve Github workflow job ids to make it easier to reference them from Github settings by jenstroeger · Pull Request #918 · jenstroeger/python-package-template
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| build-package: | |
| check-and-build-package: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 2adc4d5.
Also, should we then rename _build.yaml to _check_and_build.yaml? The only job in this reusable workflow is also named check-and-build-package so maybe renaming the workflow file would improve consistency between file name and executed jobs? 🤔
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current file name is intuitive, and build should only pass when checks pass anyway.