Add modal for selecting duration of overrides for Loop by codebymini · Pull Request #457 · loopandlearn/LoopFollow

Summary

  • If LoopFollow is in dark mode, I think the override modal should be in dark mode too. (Edited because after upgrading phone to iOS 18.6.2 with associated reboot - the modal is in dark mode).

  • The duration slider is not working for me for override that has a set duration

  • There should be a decimal point displayed for mmol/L glucose ranges

  • LoopFollow phone: SE 3rd gen, iOS 18.6.1

    • Note - repeated the test on an iPhone 8 running iOS 16 and the modal was dark on that device
    • edited to add: After updating the SE to iOS 18.6.2 with associated reboot - the modal is in dark mode
    • However, the duration for a defined duration override still could not be adjusted

Test

This test was performed using a Loop URL from a phone that uses mmol/L.

build dev branch to remind me of how the override interface works

  • when selecting the override, it asks if you want to enable it

in other words: Before: User taps override → Simple confirmation dialog → Override activates with preset duration

build this branch

test with an indefinite override from LoopFollow override screen

  • user can just accept as it
  • user can modify an indefinite override to specific duration from 15 minutes to 24 hours and return to indefinite

test with a defined-duration override from LoopFollow override screen

  • user can just accept as it
  • user should be able to modify the duration - but the slider is not working

The white full-screen modal is really high-contrast in the evening with a LoopFollow phone in dark mode.

  • edited to add: After updating the SE to iOS 18.6.2 with associated reboot - the modal is in dark mode

Also, the target should show one value after the decimal point for mmol/L. The sedentary override on the Looping phone is 5,5 to 6,1.

lf-pr457-formating