Home Original page

[TimePicker] Inherit M3 timepicker button style from M3 button style by pubiqq · Pull Request #5026 · material-components/material-components-android

@pubiqq

@pubiqq

drchen

<item name="clockNumberTextColor">@color/material_timepicker_clock_text_color</item>
</style>

<style name="Widget.Material3.MaterialTimePicker.Button" parent="Widget.MaterialComponents.TimePicker.Button">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intended and what's the reason behind this. I'll let someone else to check.

@drchen

Dan can you take a look and check why we made the inheritance like this at the beginning?

@dsn5ft

@drchen it looks like you created this style so you may be able to remember better than me 😄

a1d09ac

But we either have to choose between:

  1. inherit from M2 timepicker button and then duplicate M3 button attrs here
  2. inherit from M3 button and duplicate M2 timepicker button attrs here as needed

Right? #2 seems like it would be less duplication / easier to maintain?