fix(util): update waitForTraceRoute reset logic by grleblanc · Pull Request #785

fix(util): update waitForTraceRoute reset logic by grleblanc · Pull Request #785 · meshtastic/python

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, otherwise LGTM

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.50%. Comparing base (9281c4a) to head (04a0ff6).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
meshtastic/util.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   59.48%   59.50%   +0.01%     
==========================================
  Files          24       24              
  Lines        4122     4121       -1     
==========================================
  Hits         2452     2452              
+ Misses       1670     1669       -1

Flag	Coverage Δ
unittests	`59.50% <66.66%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

I've also been running this change locally off master for a little bit now and all is well so far.

Any plans to release this to the registry?