add --set-is-unmessageable to CLI commands by pdxlocations · Pull Request #794 · meshtastic/python
allows:
meshtastic --set-is-unmessagable true
meshtastic --set-is-unmessageable true
meshtastic --set-is-unmessagable false
meshtastic --set-is-unmessageable false
Codecov Report
Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
Project coverage is 59.82%. Comparing base (
c55f1ef) to head (17f7e8e).
Report is 29 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| meshtastic/node.py | 75.00% | 1 Missing ⚠️ |
Additional details and impacted files
@@ Coverage Diff @@ ## master #794 +/- ## ========================================== - Coverage 59.90% 59.82% -0.09% ========================================== Files 24 24 Lines 4163 4184 +21 ========================================== + Hits 2494 2503 +9 - Misses 1669 1681 +12
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 59.82% <92.30%> (-0.09%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this should be rearranged a little to match other code, but otherwise looks reasonable to me.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny thing but otherwise good to go. feel free to ping me in discord if I lose track of it again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters