Do not parse template arguments in JavaScript files. by mprobst · Pull Request #36673 · microsoft/TypeScript
@DanielRosenwasser
The results of the perf run you requested are in!
Here they are:
Comparison Report - master..36673
| Metric | master | 36673 | Delta | Best | Worst |
|---|---|---|---|---|---|
| Angular - node (v10.16.3, x64) | |||||
| Memory used | 343,962k (± 0.01%) | 343,423k (± 0.01%) | -540k (- 0.16%) | 343,333k | 343,543k |
| Parse Time | 2.00s (± 0.50%) | 2.02s (± 0.70%) | +0.01s (+ 0.60%) | 2.00s | 2.06s |
| Bind Time | 0.81s (± 0.64%) | 0.82s (± 0.54%) | +0.01s (+ 0.86%) | 0.81s | 0.83s |
| Check Time | 4.73s (± 0.29%) | 4.74s (± 0.80%) | +0.01s (+ 0.23%) | 4.64s | 4.79s |
| Emit Time | 5.19s (± 0.59%) | 5.21s (± 1.48%) | +0.02s (+ 0.42%) | 5.12s | 5.51s |
| Total Time | 12.73s (± 0.25%) | 12.78s (± 0.87%) | +0.05s (+ 0.40%) | 12.65s | 13.19s |
| Monaco - node (v10.16.3, x64) | |||||
| Memory used | 339,143k (± 0.03%) | 339,267k (± 0.03%) | +124k (+ 0.04%) | 339,064k | 339,415k |
| Parse Time | 1.58s (± 0.55%) | 1.58s (± 0.92%) | +0.00s (+ 0.32%) | 1.55s | 1.61s |
| Bind Time | 0.71s (± 0.78%) | 0.72s (± 0.51%) | +0.00s (+ 0.56%) | 0.71s | 0.72s |
| Check Time | 4.91s (± 0.64%) | 4.89s (± 0.64%) | -0.01s (- 0.29%) | 4.83s | 4.95s |
| Emit Time | 2.74s (± 0.35%) | 2.74s (± 0.83%) | -0.00s (- 0.11%) | 2.69s | 2.80s |
| Total Time | 9.95s (± 0.32%) | 9.94s (± 0.49%) | -0.01s (- 0.08%) | 9.80s | 10.02s |
| TFS - node (v10.16.3, x64) | |||||
| Memory used | 302,064k (± 0.02%) | 302,062k (± 0.02%) | -2k (- 0.00%) | 301,968k | 302,186k |
| Parse Time | 1.20s (± 0.68%) | 1.22s (± 0.67%) | +0.01s (+ 1.16%) | 1.20s | 1.24s |
| Bind Time | 0.66s (± 1.03%) | 0.67s (± 1.02%) | +0.00s (+ 0.15%) | 0.65s | 0.68s |
| Check Time | 4.39s (± 0.39%) | 4.42s (± 0.82%) | +0.03s (+ 0.78%) | 4.35s | 4.49s |
| Emit Time | 2.89s (± 0.92%) | 2.88s (± 0.69%) | -0.01s (- 0.48%) | 2.82s | 2.91s |
| Total Time | 9.15s (± 0.40%) | 9.18s (± 0.37%) | +0.03s (+ 0.34%) | 9.12s | 9.26s |
| material-ui - node (v10.16.3, x64) | |||||
| Memory used | 459,445k (± 0.01%) | 459,143k (± 0.01%) | -303k (- 0.07%) | 459,034k | 459,262k |
| Parse Time | 2.04s (± 0.29%) | 2.04s (± 0.40%) | -0.00s (- 0.05%) | 2.02s | 2.06s |
| Bind Time | 0.65s (± 1.88%) | 0.65s (± 1.57%) | 0.00s ( 0.00%) | 0.63s | 0.67s |
| Check Time | 12.93s (± 0.92%) | 12.85s (± 0.78%) | -0.07s (- 0.57%) | 12.72s | 13.21s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 15.62s (± 0.75%) | 15.55s (± 0.67%) | -0.07s (- 0.46%) | 15.39s | 15.92s |
| Angular - node (v12.1.0, x64) | |||||
| Memory used | 320,857k (± 0.13%) | 320,761k (± 0.02%) | -96k (- 0.03%) | 320,601k | 320,882k |
| Parse Time | 1.98s (± 0.60%) | 1.99s (± 0.56%) | +0.01s (+ 0.71%) | 1.97s | 2.02s |
| Bind Time | 0.80s (± 1.34%) | 0.80s (± 0.42%) | +0.00s (+ 0.25%) | 0.80s | 0.81s |
| Check Time | 4.63s (± 0.83%) | 4.66s (± 0.56%) | +0.03s (+ 0.69%) | 4.62s | 4.74s |
| Emit Time | 5.37s (± 1.29%) | 5.36s (± 0.64%) | -0.01s (- 0.19%) | 5.31s | 5.44s |
| Total Time | 12.78s (± 0.75%) | 12.82s (± 0.22%) | +0.03s (+ 0.26%) | 12.77s | 12.89s |
| Monaco - node (v12.1.0, x64) | |||||
| Memory used | 321,581k (± 0.02%) | 321,575k (± 0.03%) | -6k (- 0.00%) | 321,394k | 321,817k |
| Parse Time | 1.54s (± 0.99%) | 1.56s (± 0.48%) | +0.02s (+ 1.10%) | 1.54s | 1.57s |
| Bind Time | 0.69s (± 1.40%) | 0.69s (± 0.99%) | +0.01s (+ 0.87%) | 0.69s | 0.72s |
| Check Time | 4.65s (± 1.27%) | 4.68s (± 0.37%) | +0.03s (+ 0.62%) | 4.64s | 4.73s |
| Emit Time | 2.78s (± 1.48%) | 2.79s (± 0.42%) | +0.02s (+ 0.61%) | 2.77s | 2.82s |
| Total Time | 9.66s (± 1.21%) | 9.73s (± 0.20%) | +0.07s (+ 0.67%) | 9.68s | 9.76s |
| TFS - node (v12.1.0, x64) | |||||
| Memory used | 286,569k (± 0.01%) | 286,574k (± 0.03%) | +5k (+ 0.00%) | 286,459k | 286,772k |
| Parse Time | 1.23s (± 0.74%) | 1.24s (± 0.66%) | +0.01s (+ 0.49%) | 1.22s | 1.26s |
| Bind Time | 0.64s (± 0.81%) | 0.64s (± 0.90%) | +0.00s (+ 0.63%) | 0.63s | 0.65s |
| Check Time | 4.30s (± 0.59%) | 4.32s (± 0.58%) | +0.02s (+ 0.44%) | 4.26s | 4.38s |
| Emit Time | 2.92s (± 0.80%) | 2.94s (± 1.25%) | +0.02s (+ 0.82%) | 2.89s | 3.05s |
| Total Time | 9.09s (± 0.46%) | 9.14s (± 0.38%) | +0.05s (+ 0.57%) | 9.07s | 9.22s |
| material-ui - node (v12.1.0, x64) | |||||
| Memory used | 437,822k (± 0.01%) | 437,380k (± 0.07%) | -441k (- 0.10%) | 436,236k | 437,679k |
| Parse Time | 2.04s (± 0.88%) | 2.04s (± 0.29%) | -0.00s (- 0.10%) | 2.02s | 2.05s |
| Bind Time | 0.64s (± 0.94%) | 0.63s (± 0.82%) | -0.00s (- 0.63%) | 0.62s | 0.64s |
| Check Time | 11.65s (± 0.72%) | 11.61s (± 0.79%) | -0.04s (- 0.31%) | 11.43s | 11.85s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 14.32s (± 0.55%) | 14.28s (± 0.66%) | -0.04s (- 0.29%) | 14.08s | 14.52s |
| Angular - node (v8.9.0, x64) | |||||
| Memory used | 340,444k (± 0.01%) | 340,091k (± 0.01%) | -352k (- 0.10%) | 339,972k | 340,191k |
| Parse Time | 2.53s (± 0.27%) | 2.53s (± 0.37%) | +0.00s (+ 0.04%) | 2.51s | 2.54s |
| Bind Time | 0.85s (± 0.58%) | 0.85s (± 0.70%) | -0.01s (- 0.94%) | 0.83s | 0.86s |
| Check Time | 5.35s (± 0.46%) | 5.36s (± 0.52%) | +0.01s (+ 0.09%) | 5.30s | 5.42s |
| Emit Time | 5.90s (± 1.08%) | 5.96s (± 1.13%) | +0.06s (+ 0.97%) | 5.87s | 6.15s |
| Total Time | 14.64s (± 0.51%) | 14.69s (± 0.46%) | +0.05s (+ 0.37%) | 14.57s | 14.84s |
| Monaco - node (v8.9.0, x64) | |||||
| Memory used | 340,492k (± 0.01%) | 340,497k (± 0.01%) | +5k (+ 0.00%) | 340,379k | 340,609k |
| Parse Time | 1.87s (± 0.43%) | 1.87s (± 0.40%) | +0.00s (+ 0.11%) | 1.86s | 1.89s |
| Bind Time | 0.88s (± 0.25%) | 0.88s (± 0.77%) | +0.00s (+ 0.34%) | 0.87s | 0.90s |
| Check Time | 5.40s (± 0.62%) | 5.41s (± 0.43%) | +0.01s (+ 0.19%) | 5.36s | 5.45s |
| Emit Time | 3.22s (± 0.37%) | 3.23s (± 0.56%) | +0.01s (+ 0.25%) | 3.19s | 3.27s |
| Total Time | 11.37s (± 0.36%) | 11.40s (± 0.37%) | +0.03s (+ 0.23%) | 11.33s | 11.47s |
| TFS - node (v8.9.0, x64) | |||||
| Memory used | 303,833k (± 0.02%) | 303,847k (± 0.02%) | +15k (+ 0.00%) | 303,752k | 303,972k |
| Parse Time | 1.54s (± 0.48%) | 1.54s (± 0.53%) | -0.00s (- 0.00%) | 1.53s | 1.56s |
| Bind Time | 0.67s (± 0.77%) | 0.67s (± 0.71%) | -0.00s (- 0.60%) | 0.66s | 0.68s |
| Check Time | 5.03s (± 1.38%) | 4.94s (± 0.95%) | -0.09s (- 1.79%) | 4.85s | 5.09s |
| Emit Time | 3.03s (± 2.64%) | 3.13s (± 1.85%) | +0.10s (+ 3.14%) | 2.91s | 3.22s |
| Total Time | 10.27s (± 0.35%) | 10.28s (± 0.39%) | +0.00s (+ 0.03%) | 10.21s | 10.39s |
| material-ui - node (v8.9.0, x64) | |||||
| Memory used | 463,640k (± 0.01%) | 463,426k (± 0.01%) | -214k (- 0.05%) | 463,334k | 463,499k |
| Parse Time | 2.41s (± 0.34%) | 2.40s (± 0.70%) | -0.02s (- 0.75%) | 2.36s | 2.43s |
| Bind Time | 0.78s (± 0.85%) | 0.77s (± 0.96%) | -0.01s (- 1.66%) | 0.76s | 0.79s |
| Check Time | 17.19s (± 1.33%) | 17.11s (± 1.13%) | -0.08s (- 0.46%) | 16.59s | 17.49s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 20.39s (± 1.12%) | 20.28s (± 1.02%) | -0.11s (- 0.53%) | 19.73s | 20.71s |
| Angular - node (v8.9.0, x86) | |||||
| Memory used | 195,323k (± 0.03%) | 195,070k (± 0.01%) | -253k (- 0.13%) | 195,004k | 195,116k |
| Parse Time | 2.45s (± 0.82%) | 2.47s (± 1.17%) | +0.02s (+ 0.82%) | 2.42s | 2.56s |
| Bind Time | 0.99s (± 0.62%) | 0.99s (± 0.66%) | -0.00s (- 0.10%) | 0.97s | 1.00s |
| Check Time | 4.83s (± 0.84%) | 4.87s (± 1.02%) | +0.03s (+ 0.68%) | 4.79s | 5.01s |
| Emit Time | 5.95s (± 1.07%) | 5.93s (± 1.13%) | -0.02s (- 0.27%) | 5.77s | 6.08s |
| Total Time | 14.22s (± 0.67%) | 14.26s (± 0.82%) | +0.04s (+ 0.26%) | 14.06s | 14.62s |
| Monaco - node (v8.9.0, x86) | |||||
| Memory used | 193,511k (± 0.02%) | 193,501k (± 0.03%) | -10k (- 0.01%) | 193,355k | 193,640k |
| Parse Time | 1.92s (± 0.99%) | 1.91s (± 0.46%) | -0.02s (- 0.88%) | 1.88s | 1.92s |
| Bind Time | 0.70s (± 0.43%) | 0.70s (± 1.43%) | +0.01s (+ 0.86%) | 0.69s | 0.74s |
| Check Time | 5.50s (± 0.48%) | 5.49s (± 0.47%) | -0.01s (- 0.18%) | 5.43s | 5.55s |
| Emit Time | 2.68s (± 0.65%) | 2.68s (± 0.96%) | +0.00s (+ 0.11%) | 2.63s | 2.74s |
| Total Time | 10.80s (± 0.38%) | 10.78s (± 0.40%) | -0.02s (- 0.17%) | 10.66s | 10.86s |
| TFS - node (v8.9.0, x86) | |||||
| Memory used | 173,771k (± 0.01%) | 173,763k (± 0.02%) | -8k (- 0.00%) | 173,678k | 173,874k |
| Parse Time | 1.58s (± 0.67%) | 1.61s (± 1.15%) | +0.03s (+ 2.03%) | 1.57s | 1.65s |
| Bind Time | 0.64s (± 1.01%) | 0.65s (± 1.05%) | +0.01s (+ 1.25%) | 0.64s | 0.67s |
| Check Time | 4.68s (± 0.79%) | 4.69s (± 0.55%) | +0.01s (+ 0.15%) | 4.63s | 4.75s |
| Emit Time | 2.80s (± 1.33%) | 2.82s (± 1.10%) | +0.02s (+ 0.54%) | 2.73s | 2.87s |
| Total Time | 9.70s (± 0.56%) | 9.76s (± 0.52%) | +0.06s (+ 0.60%) | 9.63s | 9.89s |
| material-ui - node (v8.9.0, x86) | |||||
| Memory used | 262,544k (± 0.02%) | 262,408k (± 0.02%) | -136k (- 0.05%) | 262,299k | 262,499k |
| Parse Time | 2.45s (± 0.47%) | 2.47s (± 0.78%) | +0.03s (+ 1.06%) | 2.44s | 2.53s |
| Bind Time | 0.67s (± 1.91%) | 0.67s (± 1.26%) | +0.00s (+ 0.45%) | 0.66s | 0.69s |
| Check Time | 15.67s (± 0.51%) | 15.66s (± 0.74%) | -0.01s (- 0.06%) | 15.45s | 15.91s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 18.79s (± 0.40%) | 18.80s (± 0.57%) | +0.02s (+ 0.09%) | 18.60s | 19.02s |
System
| Machine Name | ts-ci-ubuntu |
|---|---|
| Platform | linux 4.4.0-166-generic |
| Architecture | x64 |
| Available Memory | 16 GB |
| Available Memory | 1 GB |
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
Hosts
- node (v10.16.3, x64)
- node (v12.1.0, x64)
- node (v8.9.0, x64)
- node (v8.9.0, x86)
Scenarios
- Angular - node (v10.16.3, x64)
- Angular - node (v12.1.0, x64)
- Angular - node (v8.9.0, x64)
- Angular - node (v8.9.0, x86)
- Monaco - node (v10.16.3, x64)
- Monaco - node (v12.1.0, x64)
- Monaco - node (v8.9.0, x64)
- Monaco - node (v8.9.0, x86)
- TFS - node (v10.16.3, x64)
- TFS - node (v12.1.0, x64)
- TFS - node (v8.9.0, x64)
- TFS - node (v8.9.0, x86)
- material-ui - node (v10.16.3, x64)
- material-ui - node (v12.1.0, x64)
- material-ui - node (v8.9.0, x64)
- material-ui - node (v8.9.0, x86)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | 36673 | 10 |
| Baseline | master | 10 |