Make the falsy part of any/unknown any/unknown by andrewbranch · Pull Request #39529 · microsoft/TypeScript
@DanielRosenwasser
The results of the perf run you requested are in!
Here they are:
Comparison Report - master..39529
| Metric | master | 39529 | Delta | Best | Worst |
|---|---|---|---|---|---|
| Angular - node (v10.16.3, x64) | |||||
| Memory used | 343,939k (± 0.02%) | 343,491k (± 0.02%) | -448k (- 0.13%) | 343,289k | 343,611k |
| Parse Time | 2.01s (± 0.58%) | 2.01s (± 0.66%) | +0.00s (+ 0.20%) | 1.98s | 2.04s |
| Bind Time | 0.82s (± 0.84%) | 0.81s (± 0.93%) | -0.00s (- 0.12%) | 0.80s | 0.84s |
| Check Time | 4.73s (± 0.37%) | 4.75s (± 0.67%) | +0.02s (+ 0.38%) | 4.65s | 4.82s |
| Emit Time | 5.18s (± 0.46%) | 5.17s (± 0.75%) | -0.01s (- 0.12%) | 5.10s | 5.30s |
| Total Time | 12.73s (± 0.24%) | 12.74s (± 0.58%) | +0.01s (+ 0.09%) | 12.62s | 12.93s |
| Monaco - node (v10.16.3, x64) | |||||
| Memory used | 339,142k (± 0.02%) | 339,221k (± 0.03%) | +80k (+ 0.02%) | 339,015k | 339,472k |
| Parse Time | 1.59s (± 0.82%) | 1.58s (± 0.53%) | -0.01s (- 0.69%) | 1.55s | 1.59s |
| Bind Time | 0.71s (± 0.56%) | 0.71s (± 0.56%) | 0.00s ( 0.00%) | 0.70s | 0.72s |
| Check Time | 4.89s (± 0.73%) | 4.88s (± 0.54%) | -0.01s (- 0.12%) | 4.83s | 4.96s |
| Emit Time | 2.77s (± 1.23%) | 2.75s (± 1.33%) | -0.02s (- 0.58%) | 2.72s | 2.89s |
| Total Time | 9.96s (± 0.59%) | 9.92s (± 0.52%) | -0.03s (- 0.34%) | 9.81s | 10.05s |
| TFS - node (v10.16.3, x64) | |||||
| Memory used | 302,080k (± 0.02%) | 302,038k (± 0.02%) | -42k (- 0.01%) | 301,898k | 302,153k |
| Parse Time | 1.22s (± 0.67%) | 1.21s (± 0.89%) | -0.01s (- 0.66%) | 1.19s | 1.23s |
| Bind Time | 0.67s (± 1.09%) | 0.67s (± 0.78%) | +0.00s (+ 0.15%) | 0.66s | 0.68s |
| Check Time | 4.40s (± 0.46%) | 4.42s (± 0.41%) | +0.02s (+ 0.57%) | 4.38s | 4.46s |
| Emit Time | 2.89s (± 0.88%) | 2.88s (± 0.97%) | -0.01s (- 0.21%) | 2.82s | 2.94s |
| Total Time | 9.17s (± 0.38%) | 9.18s (± 0.38%) | +0.02s (+ 0.19%) | 9.12s | 9.28s |
| material-ui - node (v10.16.3, x64) | |||||
| Memory used | 459,386k (± 0.01%) | 459,122k (± 0.01%) | -264k (- 0.06%) | 458,928k | 459,223k |
| Parse Time | 2.04s (± 0.29%) | 2.04s (± 0.46%) | +0.00s (+ 0.20%) | 2.02s | 2.06s |
| Bind Time | 0.65s (± 1.53%) | 0.65s (± 1.56%) | -0.00s (- 0.62%) | 0.63s | 0.68s |
| Check Time | 12.88s (± 0.54%) | 12.86s (± 0.51%) | -0.02s (- 0.14%) | 12.76s | 13.06s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 15.57s (± 0.48%) | 15.55s (± 0.42%) | -0.02s (- 0.12%) | 15.45s | 15.74s |
| Angular - node (v12.1.0, x64) | |||||
| Memory used | 321,182k (± 0.03%) | 320,630k (± 0.08%) | -552k (- 0.17%) | 319,617k | 320,905k |
| Parse Time | 1.99s (± 0.62%) | 1.98s (± 0.79%) | -0.01s (- 0.45%) | 1.95s | 2.02s |
| Bind Time | 0.80s (± 0.69%) | 0.80s (± 0.59%) | +0.00s (+ 0.12%) | 0.79s | 0.81s |
| Check Time | 4.62s (± 0.52%) | 4.64s (± 0.72%) | +0.03s (+ 0.56%) | 4.57s | 4.72s |
| Emit Time | 5.35s (± 0.66%) | 5.38s (± 0.85%) | +0.03s (+ 0.64%) | 5.31s | 5.50s |
| Total Time | 12.76s (± 0.40%) | 12.81s (± 0.66%) | +0.05s (+ 0.41%) | 12.64s | 13.00s |
| Monaco - node (v12.1.0, x64) | |||||
| Memory used | 321,547k (± 0.01%) | 321,561k (± 0.01%) | +14k (+ 0.00%) | 321,396k | 321,622k |
| Parse Time | 1.55s (± 0.84%) | 1.55s (± 0.69%) | +0.00s (+ 0.26%) | 1.52s | 1.57s |
| Bind Time | 0.69s (± 0.72%) | 0.69s (± 0.68%) | +0.00s (+ 0.58%) | 0.68s | 0.70s |
| Check Time | 4.69s (± 0.62%) | 4.67s (± 0.28%) | -0.01s (- 0.32%) | 4.64s | 4.70s |
| Emit Time | 2.81s (± 0.57%) | 2.80s (± 0.74%) | -0.01s (- 0.25%) | 2.77s | 2.85s |
| Total Time | 9.73s (± 0.43%) | 9.71s (± 0.39%) | -0.01s (- 0.15%) | 9.61s | 9.81s |
| TFS - node (v12.1.0, x64) | |||||
| Memory used | 286,528k (± 0.02%) | 286,560k (± 0.02%) | +31k (+ 0.01%) | 286,343k | 286,647k |
| Parse Time | 1.23s (± 0.76%) | 1.24s (± 0.80%) | +0.01s (+ 0.81%) | 1.22s | 1.26s |
| Bind Time | 0.64s (± 1.04%) | 0.64s (± 1.06%) | +0.00s (+ 0.63%) | 0.63s | 0.66s |
| Check Time | 4.30s (± 0.75%) | 4.31s (± 0.31%) | +0.00s (+ 0.09%) | 4.28s | 4.34s |
| Emit Time | 2.90s (± 0.92%) | 2.92s (± 0.70%) | +0.02s (+ 0.72%) | 2.88s | 2.98s |
| Total Time | 9.07s (± 0.54%) | 9.11s (± 0.35%) | +0.04s (+ 0.39%) | 9.05s | 9.19s |
| material-ui - node (v12.1.0, x64) | |||||
| Memory used | 437,515k (± 0.08%) | 437,534k (± 0.02%) | +19k (+ 0.00%) | 437,319k | 437,620k |
| Parse Time | 2.03s (± 0.68%) | 2.03s (± 0.49%) | +0.00s (+ 0.05%) | 2.00s | 2.05s |
| Bind Time | 0.63s (± 1.22%) | 0.62s (± 1.21%) | -0.00s (- 0.16%) | 0.61s | 0.64s |
| Check Time | 11.63s (± 1.00%) | 11.54s (± 0.87%) | -0.09s (- 0.75%) | 11.39s | 11.78s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 14.28s (± 0.79%) | 14.19s (± 0.70%) | -0.08s (- 0.59%) | 14.06s | 14.44s |
| Angular - node (v8.9.0, x64) | |||||
| Memory used | 340,454k (± 0.01%) | 340,105k (± 0.02%) | -349k (- 0.10%) | 339,968k | 340,227k |
| Parse Time | 2.54s (± 0.43%) | 2.53s (± 0.54%) | -0.01s (- 0.24%) | 2.51s | 2.56s |
| Bind Time | 0.85s (± 1.60%) | 0.85s (± 0.56%) | +0.00s (+ 0.12%) | 0.84s | 0.86s |
| Check Time | 5.35s (± 0.51%) | 5.36s (± 0.50%) | +0.01s (+ 0.22%) | 5.30s | 5.41s |
| Emit Time | 5.92s (± 1.02%) | 5.96s (± 0.69%) | +0.04s (+ 0.61%) | 5.86s | 6.04s |
| Total Time | 14.66s (± 0.53%) | 14.70s (± 0.24%) | +0.04s (+ 0.28%) | 14.62s | 14.78s |
| Monaco - node (v8.9.0, x64) | |||||
| Memory used | 340,465k (± 0.02%) | 340,516k (± 0.01%) | +51k (+ 0.02%) | 340,424k | 340,607k |
| Parse Time | 1.88s (± 0.41%) | 1.87s (± 0.62%) | -0.00s (- 0.05%) | 1.86s | 1.91s |
| Bind Time | 0.88s (± 0.86%) | 0.88s (± 0.39%) | -0.00s (- 0.11%) | 0.88s | 0.89s |
| Check Time | 5.41s (± 0.42%) | 5.41s (± 0.65%) | +0.00s (+ 0.04%) | 5.33s | 5.50s |
| Emit Time | 3.24s (± 0.90%) | 3.22s (± 0.49%) | -0.02s (- 0.71%) | 3.18s | 3.25s |
| Total Time | 11.41s (± 0.40%) | 11.39s (± 0.36%) | -0.02s (- 0.18%) | 11.30s | 11.51s |
| TFS - node (v8.9.0, x64) | |||||
| Memory used | 303,847k (± 0.02%) | 303,824k (± 0.01%) | -23k (- 0.01%) | 303,734k | 303,926k |
| Parse Time | 1.54s (± 0.46%) | 1.54s (± 0.55%) | +0.00s (+ 0.13%) | 1.53s | 1.56s |
| Bind Time | 0.67s (± 0.70%) | 0.67s (± 1.00%) | -0.00s (- 0.45%) | 0.65s | 0.68s |
| Check Time | 5.06s (± 1.21%) | 4.98s (± 1.26%) | -0.08s (- 1.52%) | 4.91s | 5.16s |
| Emit Time | 2.99s (± 2.76%) | 3.10s (± 2.65%) | +0.11s (+ 3.68%) | 2.88s | 3.23s |
| Total Time | 10.26s (± 0.41%) | 10.29s (± 0.38%) | +0.03s (+ 0.28%) | 10.22s | 10.39s |
| material-ui - node (v8.9.0, x64) | |||||
| Memory used | 463,623k (± 0.01%) | 463,463k (± 0.01%) | -160k (- 0.03%) | 463,365k | 463,556k |
| Parse Time | 2.39s (± 0.64%) | 2.38s (± 0.38%) | -0.01s (- 0.25%) | 2.37s | 2.40s |
| Bind Time | 0.78s (± 1.13%) | 0.77s (± 1.36%) | -0.00s (- 0.51%) | 0.75s | 0.79s |
| Check Time | 17.18s (± 1.31%) | 17.13s (± 0.64%) | -0.05s (- 0.28%) | 16.86s | 17.39s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 20.34s (± 1.15%) | 20.29s (± 0.57%) | -0.05s (- 0.27%) | 19.99s | 20.57s |
| Angular - node (v8.9.0, x86) | |||||
| Memory used | 195,293k (± 0.01%) | 195,125k (± 0.03%) | -167k (- 0.09%) | 195,051k | 195,365k |
| Parse Time | 2.45s (± 0.71%) | 2.46s (± 1.13%) | +0.01s (+ 0.45%) | 2.42s | 2.55s |
| Bind Time | 0.99s (± 0.67%) | 0.99s (± 0.53%) | -0.00s (- 0.10%) | 0.98s | 1.00s |
| Check Time | 4.83s (± 0.71%) | 4.83s (± 0.53%) | 0.00s ( 0.00%) | 4.76s | 4.88s |
| Emit Time | 5.91s (± 0.94%) | 5.89s (± 1.00%) | -0.03s (- 0.42%) | 5.73s | 6.00s |
| Total Time | 14.18s (± 0.44%) | 14.17s (± 0.58%) | -0.01s (- 0.08%) | 13.92s | 14.35s |
| Monaco - node (v8.9.0, x86) | |||||
| Memory used | 193,481k (± 0.02%) | 193,491k (± 0.02%) | +11k (+ 0.01%) | 193,422k | 193,638k |
| Parse Time | 1.91s (± 0.82%) | 1.91s (± 0.82%) | +0.00s (+ 0.16%) | 1.89s | 1.96s |
| Bind Time | 0.70s (± 0.95%) | 0.70s (± 0.82%) | -0.00s (- 0.43%) | 0.69s | 0.72s |
| Check Time | 5.49s (± 0.49%) | 5.49s (± 0.39%) | -0.00s (- 0.04%) | 5.44s | 5.53s |
| Emit Time | 2.67s (± 0.88%) | 2.67s (± 0.75%) | 0.00s ( 0.00%) | 2.63s | 2.72s |
| Total Time | 10.78s (± 0.50%) | 10.78s (± 0.30%) | 0.00s ( 0.00%) | 10.71s | 10.87s |
| TFS - node (v8.9.0, x86) | |||||
| Memory used | 173,760k (± 0.04%) | 173,755k (± 0.03%) | -5k (- 0.00%) | 173,674k | 173,909k |
| Parse Time | 1.60s (± 1.18%) | 1.60s (± 1.20%) | -0.00s (- 0.06%) | 1.56s | 1.64s |
| Bind Time | 0.64s (± 0.70%) | 0.64s (± 0.53%) | -0.00s (- 0.16%) | 0.63s | 0.64s |
| Check Time | 4.65s (± 0.61%) | 4.67s (± 0.67%) | +0.02s (+ 0.41%) | 4.63s | 4.77s |
| Emit Time | 2.77s (± 0.56%) | 2.78s (± 0.80%) | +0.01s (+ 0.54%) | 2.72s | 2.84s |
| Total Time | 9.65s (± 0.33%) | 9.69s (± 0.34%) | +0.03s (+ 0.32%) | 9.62s | 9.77s |
| material-ui - node (v8.9.0, x86) | |||||
| Memory used | 262,597k (± 0.00%) | 262,395k (± 0.02%) | -203k (- 0.08%) | 262,295k | 262,495k |
| Parse Time | 2.46s (± 0.60%) | 2.44s (± 0.38%) | -0.02s (- 0.97%) | 2.42s | 2.46s |
| Bind Time | 0.67s (± 0.90%) | 0.67s (± 1.09%) | +0.00s (+ 0.45%) | 0.65s | 0.68s |
| Check Time | 15.75s (± 0.83%) | 15.75s (± 0.58%) | -0.00s (- 0.02%) | 15.50s | 15.95s |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | 0.00s ( NaN%) | 0.00s | 0.00s |
| Total Time | 18.88s (± 0.66%) | 18.85s (± 0.48%) | -0.03s (- 0.14%) | 18.62s | 19.05s |
System
| Machine Name | ts-ci-ubuntu |
|---|---|
| Platform | linux 4.4.0-166-generic |
| Architecture | x64 |
| Available Memory | 16 GB |
| Available Memory | 1 GB |
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
Hosts
- node (v10.16.3, x64)
- node (v12.1.0, x64)
- node (v8.9.0, x64)
- node (v8.9.0, x86)
Scenarios
- Angular - node (v10.16.3, x64)
- Angular - node (v12.1.0, x64)
- Angular - node (v8.9.0, x64)
- Angular - node (v8.9.0, x86)
- Monaco - node (v10.16.3, x64)
- Monaco - node (v12.1.0, x64)
- Monaco - node (v8.9.0, x64)
- Monaco - node (v8.9.0, x86)
- TFS - node (v10.16.3, x64)
- TFS - node (v12.1.0, x64)
- TFS - node (v8.9.0, x64)
- TFS - node (v8.9.0, x86)
- material-ui - node (v10.16.3, x64)
- material-ui - node (v12.1.0, x64)
- material-ui - node (v8.9.0, x64)
- material-ui - node (v8.9.0, x86)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | 39529 | 10 |
| Baseline | master | 10 |