Focus next item in list after removing breakpoint by ChrisPapp · Pull Request #96287 · microsoft/vscode
| if (this.isBodyVisible()) { | ||
| this.updateSize(); | ||
| if (this.list) { | ||
| const lastFocusIndex = this.list.getFocus()[0]; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lastFocusIndex can be undefined, since getFocus can return an empty array.
Also do not check against equality with -1.
@ChrisPapp thanks for this PR. I left some comments, once you address them we can merge this in.
Assigning to May since we are now in the endgame week and we do not accept any new features this week, only testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters