Grdowns/inactive region opacity by grdowns · Pull Request #2061 · microsoft/vscode-cpptools
| let settings: CppSettings = new CppSettings(this.RootUri); | ||
|
|
||
| let decoration: vscode.TextEditorDecorationType = vscode.window.createTextEditorDecorationType({ | ||
| opacity: String(settings.inactiveRegionOpacity) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need any error validation here?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, should be a number between 0 and 100...although maybe 0 is too low if the text becomes invisible.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't do it elsewhere in the codebase. I believe the line of thought is CppSettings should always be constructible, as this.RootUri should always be valid. @bobbrow?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Andrew is referring to the inactiveRegionOpacity setting