Tests: Add support for crud tests bypassDocumentationValidation.json by rozza · Pull Request #1687 · mongodb/mongo-java-driver
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a question.
Comment on lines +171 to +172
| def.skipNoncompliant("Find with batchSize equal to limit - batchSize is set to limit if limit is smaller") | ||
| .test("crud", "find", "Find with batchSize equal to limit"); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the rationale - in the test, the limit is not smaller, but is equal to the batchSize. What is the actual expected behaviour in the spec, is it to set batchSize to 1 over the limit, or something else? And why is the driver not doing that?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated - I'm not sure why that was there, must have been an unneeded artifact left over when developing the initial submodule code.