feat(table): allow sort by column by luka-nextcloud · Pull Request #8353 · nextcloud/text
Conversation
📝 Summary
- Resolves: Table: allow to sort by column #5993
🚧 TODO
- ...
🏁 Checklist
- Code is properly formatted (
npm run lint/npm run stylelint/composer run cs:check) - Sign-off message is added to all commits
- Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
- Documentation (README or documentation) has been updated or is not required
@luka-nextcloud Thanks a lot! That looks really great. I'll take a look at the code. Could you rebase and npm run prettier:fix on the branch to make prettier happy?
Thanks!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good.
I think it would be nice to not move the cursor around to change the sort order. I added some more detailed comments explaining how I think this would be feasible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters