Home Original page

feat(dialogs): allow to quickly show a dialog by susnux · Pull Request #1986 · nextcloud-libraries/nextcloud-dialogs

@susnux

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.93%. Comparing base (f963f8d) to head (86e8589).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
+ Coverage   43.33%   49.93%   +6.60%     
==========================================
  Files          22       22              
  Lines         773      803      +30     
  Branches       93      102       +9     
==========================================
+ Hits          335      401      +66     
+ Misses        437      401      -36     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux 

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

@susnux

CarlSchwan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but maybe wait for another review :)

skjnldsv

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough! Super clean!

@ShGKme

Confirm dialogs seem to me to be a part of UI Kit. Why add them here and not in @nextcloud/vue?

@susnux

Confirm dialogs seem to me to be a part of UI Kit. Why add them here and not in @nextcloud/vue?

I think the general idea behind this package was / is to have a framework agnostic library as replacement of legacy OCP and OC API.
While @nextcloud/vue is bound to Vue this can also be used with any other framework or no framework at all.