Miscellaneous small fixes by falbrechtskirchinger · Pull Request #3643

Miscellaneous small fixes by falbrechtskirchinger · Pull Request #3643 · nlohmann/json

Fix lgtm issues: https://lgtm.com/projects/g/nlohmann/json/alerts/?mode=list.
Fix serve_header.py always exiting with 0 error code.
Replace deprecated function use in serve_header.py.

I may leave this here for a while, in case I find more issues like this. Chances are, of course, I'll find another one moments after this one has been merged. :-)

		server_side=True, ssl_version=ssl.PROTOCOL_TLS)
		ssl_ctx = ssl.create_default_context(ssl.Purpose.CLIENT_AUTH)
		ssl_ctx.load_cert_chain(cert_file, key_file)
		httpd.socket = ssl_ctx.wrap_socket(httpd.socket, server_side=True)

Check notice

Code scanning

Use of insecure SSL/TLS version

Insecure SSL/TLS protocol version TLSv1 allowed by [call to ssl.create_default_context](1) Insecure SSL/TLS protocol version TLSv1_1 allowed by [call to ssl.create_default_context](1)

Coverage remained the same at 100.0% when pulling 5c8e359 on falbrechtskirchinger:misc-fixes into b0422f8 on nlohmann:develop.

Looks good to me.

@nlohmann I'll leave it up to you whether you'd prefer collecting more small stuff here or if you'd want to merge it now.
I'd only tweak the title once I know the final content.

I've tested server_header.py (runs and serves requests).
GDB pretty printer received some limited testing as part of the inline namespace PR, it still works on a simple JSON object.

Several items in here have made it into other PRs. I've removed them.
Looks good to me.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.