switch from global to per-process core dumps on SmartOS by misterdjules · Pull Request #894

switch from global to per-process core dumps on SmartOS by misterdjules · Pull Request #894 · nodejs/build

This allows for controlling core files limits per process (e.g per
tests).

This allows for controlling core files limits per process (e.g per
tests).

Ref: nodejs/node#14013

This comment was marked as off-topic.

@nodejs/platform-smartos , anyone else want to review?

@gibfahn May I merge these changes? I don't know what the process is for merging changes in this repository, so a bit of guidance would be appreciated in order for me to ensure that I follow any process currently established.

@gibfahn May I merge these changes? I don't know what the process is for merging changes in this repository, so a bit of guidance would be appreciated in order for me to ensure that I follow any process currently established.

If it's been reviewed and has been open for a couple of days, anyone in nodejs/build can merge. We tend to follow a more relaxed version of the core rules (so Squash and merge is fine).

Thanks for merging and for the info, I'll keep that in mind next time!