test: fix flaky test-vm-sigint-existing-handler

test: fix flaky test-vm-sigint-existing-handler · nodejs/node@be73480

2 files changed

lines changed

Original file line number	Diff line number	Diff line change
`@@ -61,16 +61,19 @@ if (process.argv[2] === 'child') {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`process.env.REPL_TEST_PPID = process.pid;`
`64`		`-const child = spawn(process.execPath, [ __filename, 'child' ], {`
`65`		`-stdio: [null, 'inherit', 'inherit']`
`66`		`-});`
`67`	`64`
	`65`	+// Set the `SIGUSR2` handler before spawning the child process to make sure
	`66`	`+// the signal is always handled.`
`68`	`67`	`process.on('SIGUSR2', common.mustCall(() => {`
`69`	`68`	`// First kill() breaks the while(true) loop, second one invokes the real`
`70`	`69`	`// signal handlers.`
`71`	`70`	`process.kill(child.pid, 'SIGINT');`
`72`	`71`	`}, 3));`
`73`	`72`
	`73`	`+const child = spawn(process.execPath, [__filename, 'child'], {`
	`74`	`+stdio: [null, 'inherit', 'inherit']`
	`75`	`+});`
	`76`	`+`
`74`	`77`	`child.on('close', function(code, signal) {`
`75`	`78`	`assert.strictEqual(signal, null);`
`76`	`79`	`assert.strictEqual(code, 0);`

Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,14 @@ if (process.argv[2] === 'child') {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`process.env.REPL_TEST_PPID = process.pid;`
	`28`	`+`
	`29`	+// Set the `SIGUSR2` handler before spawning the child process to make sure
	`30`	`+// the signal is always handled.`
`28`	`31`	`process.on('SIGUSR2', common.mustCall(() => {`
`29`	`32`	`process.kill(child.pid, 'SIGINT');`
`30`	`33`	`}));`
`31`	`34`
`32`		`-const child = spawn(process.execPath, [ __filename, 'child' ], {`
	`35`	`+const child = spawn(process.execPath, [__filename, 'child'], {`
`33`	`36`	`stdio: [null, 'pipe', 'inherit']`
`34`	`37`	`});`
`35`	`38`