tools: eslint - use `error` and `off` · nodejs/node@f7b6d19

@@ -13,67 +13,67 @@ parserOptions:

1313

rules:

1414

# Possible Errors

1515

# http://eslint.org/docs/rules/#possible-errors

16-

comma-dangle: [2, only-multiline]

17-

no-control-regex: 2

18-

no-debugger: 2

19-

no-dupe-args: 2

20-

no-dupe-keys: 2

21-

no-duplicate-case: 2

22-

no-empty-character-class: 2

23-

no-ex-assign: 2

24-

no-extra-boolean-cast: 2

25-

no-extra-parens: [2, functions]

26-

no-extra-semi: 2

27-

no-func-assign: 2

28-

no-invalid-regexp: 2

29-

no-irregular-whitespace: 2

30-

no-obj-calls: 2

31-

no-proto: 2

32-

no-template-curly-in-string: 2

33-

no-unexpected-multiline: 2

34-

no-unreachable: 2

35-

no-unsafe-negation: 2

36-

use-isnan: 2

37-

valid-typeof: 2

16+

comma-dangle: [error, only-multiline]

17+

no-control-regex: error

18+

no-debugger: error

19+

no-dupe-args: error

20+

no-dupe-keys: error

21+

no-duplicate-case: error

22+

no-empty-character-class: error

23+

no-ex-assign: error

24+

no-extra-boolean-cast: error

25+

no-extra-parens: [error, functions]

26+

no-extra-semi: error

27+

no-func-assign: error

28+

no-invalid-regexp: error

29+

no-irregular-whitespace: error

30+

no-obj-calls: error

31+

no-proto: error

32+

no-template-curly-in-string: error

33+

no-unexpected-multiline: error

34+

no-unreachable: error

35+

no-unsafe-negation: error

36+

use-isnan: error

37+

valid-typeof: error

38383939

# Best Practices

4040

# http://eslint.org/docs/rules/#best-practices

41-

dot-location: [2, property]

42-

no-fallthrough: 2

43-

no-global-assign: 2

44-

no-multi-spaces: [2, {ignoreEOLComments: true}]

45-

no-octal: 2

46-

no-redeclare: 2

47-

no-self-assign: 2

48-

no-unused-labels: 2

49-

no-useless-call: 2

50-

no-useless-concat: 2

51-

no-useless-escape: 2

52-

no-useless-return: 2

53-

no-void: 2

54-

no-with: 2

41+

dot-location: [error, property]

42+

no-fallthrough: error

43+

no-global-assign: error

44+

no-multi-spaces: [error, {ignoreEOLComments: true}]

45+

no-octal: error

46+

no-redeclare: error

47+

no-self-assign: error

48+

no-unused-labels: error

49+

no-useless-call: error

50+

no-useless-concat: error

51+

no-useless-escape: error

52+

no-useless-return: error

53+

no-void: error

54+

no-with: error

55555656

# Strict Mode

5757

# http://eslint.org/docs/rules/#strict-mode

58-

strict: [2, global]

58+

strict: [error, global]

59596060

# Variables

6161

# http://eslint.org/docs/rules/#variables

62-

no-delete-var: 2

63-

no-undef: 2

64-

no-unused-vars: [2, {args: none}]

65-

no-use-before-define: [2, {classes: true,

66-

functions: false,

67-

variables: false}]

62+

no-delete-var: error

63+

no-undef: error

64+

no-unused-vars: [error, {args: none}]

65+

no-use-before-define: [error, {classes: true,

66+

functions: false,

67+

variables: false}]

68686969

# Node.js and CommonJS

7070

# http://eslint.org/docs/rules/#nodejs-and-commonjs

71-

no-mixed-requires: 2

72-

no-new-require: 2

73-

no-path-concat: 2

74-

no-restricted-modules: [2, sys, _linklist]

71+

no-mixed-requires: error

72+

no-new-require: error

73+

no-path-concat: error

74+

no-restricted-modules: [error, sys, _linklist]

7575

no-restricted-properties:

76-

- 2

76+

- error

7777

- object: assert

7878

property: deepEqual

7979

message: Use assert.deepStrictEqual().

@@ -90,33 +90,33 @@ rules:

90909191

# Stylistic Issues

9292

# http://eslint.org/docs/rules/#stylistic-issues

93-

block-spacing: 2

94-

brace-style: [2, 1tbs, {allowSingleLine: true}]

95-

comma-spacing: 2

96-

comma-style: 2

97-

computed-property-spacing: 2

98-

eol-last: 2

99-

func-call-spacing: 2

100-

func-name-matching: 2

101-

func-style: [2, declaration, {allowArrowFunctions: true}]

102-

indent: [2, 2, {ArrayExpression: first,

103-

CallExpression: {arguments: first},

104-

FunctionDeclaration: {parameters: first},

105-

FunctionExpression: {parameters: first},

106-

MemberExpression: off,

107-

ObjectExpression: first,

108-

SwitchCase: 1}]

109-

key-spacing: [2, {mode: minimum}]

110-

keyword-spacing: 2

111-

linebreak-style: [2, unix]

112-

max-len: [2, {code: 80,

113-

ignoreRegExpLiterals: true,

114-

ignoreUrls: true,

115-

tabWidth: 2}]

116-

new-parens: 2

117-

no-mixed-spaces-and-tabs: 2

118-

no-multiple-empty-lines: [2, {max: 2, maxEOF: 0, maxBOF: 0}]

119-

no-restricted-syntax: [2, {

93+

block-spacing: error

94+

brace-style: [error, 1tbs, {allowSingleLine: true}]

95+

comma-spacing: error

96+

comma-style: error

97+

computed-property-spacing: error

98+

eol-last: error

99+

func-call-spacing: error

100+

func-name-matching: error

101+

func-style: [error, declaration, {allowArrowFunctions: true}]

102+

indent: [error, 2, {ArrayExpression: first,

103+

CallExpression: {arguments: first},

104+

FunctionDeclaration: {parameters: first},

105+

FunctionExpression: {parameters: first},

106+

MemberExpression: off,

107+

ObjectExpression: first,

108+

SwitchCase: 1}]

109+

key-spacing: [error, {mode: minimum}]

110+

keyword-spacing: error

111+

linebreak-style: [error, unix]

112+

max-len: [error, {code: 80,

113+

ignoreRegExpLiterals: true,

114+

ignoreUrls: true,

115+

tabWidth: 2}]

116+

new-parens: error

117+

no-mixed-spaces-and-tabs: error

118+

no-multiple-empty-lines: [error, {max: 2, maxEOF: 0, maxBOF: 0}]

119+

no-restricted-syntax: [error, {

120120

selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",

121121

message: "use a regular expression for second argument of assert.throws()"

122122

}, {

@@ -135,36 +135,36 @@ rules:

135135

selector: "CallExpression[callee.object.name='assert'][callee.property.name='fail'][arguments.length=1]",

136136

message: "assert.fail() message should be third argument"

137137

}]

138-

no-tabs: 2

139-

no-trailing-spaces: 2

140-

operator-linebreak: [2, after, {overrides: {'?': ignore, ':': ignore}}]

141-

quotes: [2, single, avoid-escape]

142-

semi: 2

143-

semi-spacing: 2

144-

space-before-blocks: [2, always]

145-

space-before-function-paren: [2, {

138+

no-tabs: error

139+

no-trailing-spaces: error

140+

operator-linebreak: [error, after, {overrides: {'?': ignore, ':': ignore}}]

141+

quotes: [error, single, avoid-escape]

142+

semi: error

143+

semi-spacing: error

144+

space-before-blocks: [error, always]

145+

space-before-function-paren: [error, {

146146

"anonymous": "never",

147147

"named": "never",

148148

"asyncArrow": "always"

149149

}]

150-

space-in-parens: [2, never]

151-

space-infix-ops: 2

152-

space-unary-ops: 2

150+

space-in-parens: [error, never]

151+

space-infix-ops: error

152+

space-unary-ops: error

153153154154

# ECMAScript 6

155155

# http://eslint.org/docs/rules/#ecmascript-6

156-

arrow-parens: [2, always]

157-

arrow-spacing: [2, {before: true, after: true}]

158-

constructor-super: 2

159-

no-class-assign: 2

160-

no-confusing-arrow: 2

161-

no-const-assign: 2

162-

no-dupe-class-members: 2

163-

no-new-symbol: 2

164-

no-this-before-super: 2

165-

prefer-const: [2, {ignoreReadBeforeAssign: true}]

166-

rest-spread-spacing: 2

167-

template-curly-spacing: 2

156+

arrow-parens: [error, always]

157+

arrow-spacing: [error, {before: true, after: true}]

158+

constructor-super: error

159+

no-class-assign: error

160+

no-confusing-arrow: error

161+

no-const-assign: error

162+

no-dupe-class-members: error

163+

no-new-symbol: error

164+

no-this-before-super: error

165+

prefer-const: [error, {ignoreReadBeforeAssign: true}]

166+

rest-spread-spacing: error

167+

template-curly-spacing: error

168168169169

# Custom rules in tools/eslint-rules

170170