Remove util.inherits usage internally?
Currently, util.inherits does this:
| function inherits(ctor, superCtor) { | |
| if (ctor === undefined || ctor === null) | |
| throw new ERR_INVALID_ARG_TYPE('ctor', 'Function', ctor); | |
| if (superCtor === undefined || superCtor === null) | |
| throw new ERR_INVALID_ARG_TYPE('superCtor', 'Function', superCtor); | |
| if (superCtor.prototype === undefined) { | |
| throw new ERR_INVALID_ARG_TYPE('superCtor.prototype', | |
| 'Function', superCtor.prototype); | |
| } | |
| Object.defineProperty(ctor, 'super_', { | |
| value: superCtor, | |
| writable: true, | |
| configurable: true | |
| }); | |
| Object.setPrototypeOf(ctor.prototype, superCtor.prototype); | |
| } |
Most of the code seems unnecessary for our internal use. Essentially we can just replace all the internal util.inherits usage with Object.setPrototypeOf(ctor.prototype, superCtor.prototype)
Unless someone is relying on that ctor._super property existing on our internal types..
Any thoughts?