test: refactor common.PORT to random port by guylil · Pull Request #13848 · nodejs/node

Hi, @guylil! What do you say we try to get this thing across the finish line? Here's my recommendation:

  • Remove the changes to test-tls-connect.js.
  • Rebase against current master.
  • In test-tls-client-default-ciphers.js, instead of changing common.PORT to 0, change it to a string representing a path. /foo/bar is a perfectly good choice. (I sometimes go for Homestar Runner references, so maybe /sterrance or /cannonmouth. Or whatever you want, for the most part. It doesn't matter because it's going to get ignored in the test anyway. So just as long as it's clear that it's just a placeholder.)
  • Run make test to be certain tests pass and lint rules are being followed.
  • Push it up to your branch.
  • Leave a comment here along the lines of "Hey, I updated everything, please take another look."

Hope you're up for it! And if not, thanks for the pull request anyway!