Home Original page

test: refactor indexOf uses to es6 equivalents by Bnaya · Pull Request #13853 · nodejs/node

@Bnaya

refactor indexOf uses to es6 where applicable

Refs: #12586

#goodnessSquad

benjamingr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Please feel free to also give us any feedback about the onboarding process today.

#goodnessSquad

vsemozhetbyt

@vsemozhetbyt

mscdex

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The === true part can be left out here.

vsemozhetbyt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now linter issue:

 96:24  error  Expected indentation of 14 spaces but found 23  indent-legacy

cjihrig

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits addressed.

@Bnaya 

refactor indexOf uses to es6 where applicable

Refs: nodejs#12586

@Bnaya

I've fixed the rejects, how do i make the CI run again?

@vsemozhetbyt

jasnell

aqrln

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure on linux-fips is unrelated.

@tniessen

I think these changes were already covered in #13852 (amongst others) 😕 . Thank you for your contribution, I am sorry these changes did not make it in. Keep up the good work!

This was referenced

Sep 15, 2021

This was referenced

Sep 16, 2021