Home Original page

stream: remove always-false condition check by Trott · Pull Request #41488 · nodejs/node

@Trott 

Remove comparison to null of variable guaranteed to be a boolean.

@nodejs-github-bot added the needs-ci

PRs that need a full CI run.

label

Jan 12, 2022

mcollina

benjamingr

tniessen

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 12, 2022

aduh95

@Trott Trott added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Jan 14, 2022

RaisinTen

@Trott Trott added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Jan 14, 2022

@Trott Trott deleted the guaranteed branch

January 15, 2022 00:27

Trott added a commit to Trott/io.js that referenced this pull request

Jan 15, 2022 
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.

Refs: nodejs#41488 (review)

@Trott Trott mentioned this pull request

Jan 15, 2022

targos pushed a commit that referenced this pull request

Jan 16, 2022 
Remove comparison to null of variable guaranteed to be a boolean.

PR-URL: #41488
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request

Jan 17, 2022 
Remove comparison to null of variable guaranteed to be a boolean.

PR-URL: nodejs#41488
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request

Jan 17, 2022 
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.

Refs: #41488 (review)

PR-URL: #41534
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

thedull pushed a commit to thedull/node that referenced this pull request

Jan 18, 2022 
Remove comparison to null of variable guaranteed to be a boolean.

PR-URL: nodejs#41488
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

thedull pushed a commit to thedull/node that referenced this pull request

Jan 18, 2022 
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.

Refs: nodejs#41488 (review)

PR-URL: nodejs#41534
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Jan 25, 2022 
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.

Refs: #41488 (review)

PR-URL: #41534
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request

Jan 31, 2022 
Remove comparison to null of variable guaranteed to be a boolean.

PR-URL: nodejs#41488
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request

Jan 31, 2022 
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.

Refs: nodejs#41488 (review)

PR-URL: nodejs#41534
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

danielleadams pushed a commit that referenced this pull request

Feb 1, 2022 
Remove comparison to null of variable guaranteed to be a boolean.

PR-URL: #41488
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

danielleadams pushed a commit that referenced this pull request

Feb 26, 2022 
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.

Refs: #41488 (review)

PR-URL: #41534
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>