test_runner: add classname hierarchy for JUnit reporter by mag123c · Pull Request #60220 · nodejs/node

Conversation

@mag123c

Fixes: #59417

Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had classname="test".
Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).

@nodejs-github-bot

Review requested:

  • @nodejs/test_runner

atlowChemi

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (c1402c6) to head (175d312).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60220      +/-   ##
==========================================
+ Coverage   89.77%   89.80%   +0.02%     
==========================================
  Files         672      672              
  Lines      203930   203944      +14     
  Branches    39207    39213       +6     
==========================================
+ Hits       183082   183151      +69     
+ Misses      13175    13116      -59     
- Partials     7673     7677       +4     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.33% <100.00%> (+0.02%) ⬆️
lib/internal/test_runner/tests_stream.js 89.77% <100.00%> (+0.11%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CuriousStork

mcollina

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

@nodejs-github-bot

pmarchini

@CuriousStork

Hello @MoLow

Could you take a look? Thank you.

Labels

needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.