Orama / search refinement by bmuenzenmeyer ยท Pull Request #8381 ยท nodejs/nodejs.org

@bmuenzenmeyer

Description

  • cleans up unused config
  • allows suggestion to render results

Validation

Related Issues

Started work against #8376
According to the report, #8352 introduced the regressions.
#8380 Seems to have no bearing on the behavior.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer

@bmuenzenmeyer

@vercel

@github-actions

๐Ÿ‘‹ Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! ๐Ÿ™

@codecov

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 76.35%. Comparing base (a457df9) to head (4adacbe).
โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8381      +/-   ##
==========================================
- Coverage   76.40%   76.35%   -0.05%     
==========================================
  Files         118      118              
  Lines        9928     9905      -23     
  Branches      334      334              
==========================================
- Hits         7585     7563      -22     
+ Misses       2341     2340       -1     
  Partials        2        2              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

bmuenzenmeyer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

{suggestions.map((suggestion, i) => (
<Suggestions.Item {...props} key={i} className={styles.suggestionItem}>
<SparklesIcon />
<Suggestions.Item

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot thinks it might have to do with context order or nesting... that could make sense as we moved things around across package boundaries. I will keep plugging away

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these references are now dead ๐Ÿคท

@github-actions

๐Ÿ“ฆ Build Size Comparison

Summary

Metric Value
Old Total Size 3.52 MB
New Total Size 3.52 MB
Delta -96.00 B (-0.00%)

Changes

โž• Added Assets (5)
Name Size
.next/static/chunks/1e5a81a8cbd32107.js 412.31 KB
.next/static/chunks/3fb58f63e2733161.js 204.48 KB
.next/static/chunks/107c1096b2882a57.js 67.67 KB
.next/static/chunks/72a467d2bf772712.js 67.67 KB
.next/static/chunks/9f4598e4f234f0fc.js 412.31 KB
โž– Removed Assets (5)
Name Size
.next/static/chunks/0a3981701cc22c30.js 412.26 KB
.next/static/chunks/f7cdff8df33fc250.js 204.48 KB
.next/static/chunks/0b1e2cdfc2d5e8d7.js 67.76 KB
.next/static/chunks/ab5ee85dfc75ec81.js 67.76 KB
.next/static/chunks/8aac7e00673256b6.js 412.26 KB