Update event-loop-timers-and-nexttick.md by slavamuravey ยท Pull Request #8611 ยท nodejs/nodejs.org
I investigated libuv uv_run function and libuv Design overview section and I propose to correct Node.js documentation related with event loop phases order.
It is a common misconception to think that the timer phase is the first one. Actually, it is the last one within event loop iteration.
๐ Codeowner Review Request
The following codeowners have been identified for the changed files:
Team reviewers: @nodejs/nodejs-website
Please review the changes when you have a chance. Thank you! ๐
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nodejs/timers
Codecov Report
โ
All modified and coverable lines are covered by tests.
โ
Project coverage is 75.28%. Comparing base (7ec1349) to head (2eff870).
โ ๏ธ Report is 3 commits behind head on main.
โ
All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@ ## main #8611 +/- ## ========================================== + Coverage 75.27% 75.28% +0.01% ========================================== Files 105 105 Lines 9242 9242 Branches 326 326 ========================================== + Hits 6957 6958 +1 + Misses 2283 2282 -1 Partials 2 2
โ View full report in Codecov by Sentry.
๐ข Have feedback on the report? Share it here.
@slavamuravey Quality check failed. Could you format the files with pnpm prettier:fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters