fix(Editor): guard calls for unavailable list extensions by dropdead619 · Pull Request #6100 · nuxt/ui
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/runtime/utils/editor.ts
📝 Walkthrough
Walkthrough
This change refactors list type handling in the editor utility to support runtime detection of available list extensions rather than relying on hard-coded assumptions. Two new helper functions are introduced: getAvailableListTypes(editor) to identify active list extensions and liftFromLists(chain, editor) to sequentially unwrap available list wrappers. The canExecute check, list unwrapping logic, and list type conversion now use these runtime checks to determine which list node types are available, replacing compile-time references to bulletList, orderedList, and taskList.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | ⚠️ Warning | Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly describes the main change: guarding lift() calls for unavailable list extensions to prevent runtime errors. |
| Description check | ✅ Passed | The description is directly related to the changeset, explaining the bug, root cause (taskList extension not always present), and the solution implemented. |
| Linked Issues check | ✅ Passed | The PR successfully addresses issue #6099 by implementing dynamic list type handling that prevents errors when taskList or other extensions are unavailable. |
| Out of Scope Changes check | ✅ Passed | All changes in editor.ts are focused on fixing the list type handling issue described in #6099; no out-of-scope changes detected. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
- 📝 Generate docstrings (stacked PR)
- 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.