Use atc repo for shared code by philschatz · Pull Request #115 · oerpub/github-bookeditor
Conversation
im assuming that the many files you deleted are replaced in the atc repo? that makes the atc repo a dependency of gh-book even outside the context of connexions right? i thought we were aiming for the reverse relationship, not sure how i feel about that. @kathi-fletcher and thoughts?
My thoughts on splitting up the repos:
- make
gh-bookdepend onatc - create
commonrepo and makeatcdepend oncommon(delete ~5 files; they would remain inatc) - change
gh-bookto depend oncommon(1 line change) - Prefix each repo so requirejs config can be shorter
i'm cool with making gh-book depend on atc as an interim step but as a permanent architecture it bothers me since gh-book may be embedded in other environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters