Use atc repo for shared code by philschatz · Pull Request #115 · oerpub/github-bookeditor

Conversation

@philschatz

Step towards making a common shared repo gh-book and atc

Depends on #107

Commits start with "include atc project as bower component" 6d23921

EpubContainer for gh-book and WorkspaceRoot for atc
this causes problems when filteredCollection tries to keep its
collection in sync
it should at the very least send @ as an argument
Conflicts:
	scripts/gh-book/app.coffee
Conflicts:
	scripts/gh-book/app.coffee
Conflicts:
	scripts/views/layouts/workspace/sidebar.coffee

@TomWoodward

im assuming that the many files you deleted are replaced in the atc repo? that makes the atc repo a dependency of gh-book even outside the context of connexions right? i thought we were aiming for the reverse relationship, not sure how i feel about that. @kathi-fletcher and thoughts?

@philschatz

My thoughts on splitting up the repos:

  1. make gh-book depend on atc
  2. create common repo and make atc depend on common (delete ~5 files; they would remain in atc)
  3. change gh-book to depend on common (1 line change)
  4. Prefix each repo so requirejs config can be shorter

@TomWoodward

i'm cool with making gh-book depend on atc as an interim step but as a permanent architecture it bothers me since gh-book may be embedded in other environments

@izak

@kathi-fletcher

I am going to close this PR since we have another one on the same topic.