Home Original page

Deprecate Zipkin exporter by michaeljohnalbers · Pull Request #7974 · open-telemetry/opentelemetry-java

@michaeljohnalbers

Deprecates the Zipkin exporter and removes all dependencies on internal classes. This involved copying several classes into a sub-package of the Zipkin exporter package. There is a README.md in this package with a short explanation. Several test classes had to be updated to handle the deprecation.

First part of implementing #7863

@linux-foundation-easycla

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (d6ad3ae) to head (5d21c39).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #7974   +/-   ##
=========================================
  Coverage     90.16%   90.16%           
  Complexity     7478     7478           
=========================================
  Files           836      836           
  Lines         22550    22550           
  Branches       2224     2224           
=========================================
  Hits          20333    20333           
  Misses         1515     1515           
  Partials        702      702

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg

I think we should just mark the zipkin exporter as deprecated for now and come back to the problem of removing shared internal code later.

There are a couple of things we could do with the shared internal code which don't involve copying into the zipkin exporter:

  • Promote those classes to our public API
  • Carve out a new category of packages, maybe called *.tools.* or *.utils.*, which we guarantee from an API compatibility standpoint, but advertise as "not for public consumption". Move the shared internal code to this new category of packages.

@michaeljohnalbers

@michaeljohnalbers

@jack-berg I've updated the PR to remove copying to internal code.

jkwatson

jkwatson

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jack-berg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@otelbot

Thank you for your contribution @michaeljohnalbers! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.