chore: mark integration tests by SoulPancake · Pull Request #248 · openfga/python-sdk
Important
Review skipped
Auto incremental reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Note
Other AI code review bot(s) detected
CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.
Walkthrough
The changes introduce infrastructure for marking and running integration tests separately. A new Makefile target executes integration-only tests, the pyproject.toml defines and enforces the integration marker, and error integration tests are decorated with the integration marker.
Changes
| Cohort / File(s) | Summary |
|---|---|
Test infrastructure setup Makefile, pyproject.toml |
Added test-integration Makefile target with pytest marker filtering and coverage options. Added strict-markers enforcement in pyproject.toml with a new integration marker for tests requiring a running OpenFGA server. |
Integration test marking test/error_integration_test.py |
Applied @pytest.mark.integration decorator to TestErrorIntegration and TestErrorIntegrationSync classes for proper test collection. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'chore: mark integration tests' directly and clearly summarizes the main change in the pull request, which adds pytest integration markers to test classes and infrastructure support. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.