Add py.typed marker for better mypy support by manuel-lang · Pull Request #251 · openfga/python-sdk
This PR aims to provide the necessary additions for mypy typing support.
Description
What problem is being solved?
- For proper mypy support, a py.typed marker is missing as pointed out here.
How is it being solved?
The py.typed marker is added with an empty file.
References
- closes mypy type hints #109
Review Checklist
- I have clicked on "allow edits by maintainers".
- I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
- The correct base branch is being used, if not
main - I have added tests to validate that the change in functionality is working as expected
Important
Review skipped
Review was skipped as selected files did not have any reviewable changes.
💤 Files selected but had no reviewable changes (1)
- openfga_sdk/py.typed
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.17%. Comparing base (9a67559) to head (b70d32a).
❌ Your project status has failed because the head coverage (71.17%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@ ## main #251 +/- ## ======================================= Coverage 71.17% 71.17% ======================================= Files 137 137 Lines 11100 11100 ======================================= Hits 7900 7900 Misses 3200 3200
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because I was confused why an empty file would be enough and make a difference - this is expected and part of PEP-561.
Thanks @manuel-lang!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters