[SREP-993] fix: pass env for 4.17+ monitor plugin by feichashao · Pull Request #727 · openshift/backplane-cli
What type of PR is this?
- Bug
- Feature
- Documentation
- Test Coverage
- Clean Up
- Others
What this PR does / Why we need it?
This PR applies the changes in #718 and add corresponding unit tests.
From OCP 4.17, the monitoring plugin in console no longer require nginx, instead, we should pass a PORT environment variable for it to listen.
This is to fix the issue in https://issues.redhat.com/browse/SREP-608
Which Jira/Github issue(s) does this PR fix?
https://issues.redhat.com/browse/SREP-993
Special notes for your reviewer
- Tested locally with MacOS/Podman, works for 4.16 and 4.19 clusters.
Unit Test Coverage
Guidelines
- If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
- If it's a bug fix for an existing sub-command, please cover 70% of the code
Test coverage checks
- Added unit tests
- Created jira card to add unit test
- This PR may not need unit tests
Pre-checks (if applicable)
- Ran unit tests locally
- Validated the changes in a cluster
- Included documentation changes with PR