chore: Migrate repository to golangci-lint v2 by MateSaary · Pull Request #811 · openshift/backplane-cli

What type of PR is this?

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

This PR migrates golangci-lint from version 1.61 to the latest, 2.5. Due to the stricter linting introduced (particularly with errcheck), quite a few updates to existing code was needed.

Not sure if we generally like this change appearance/readability wise but it does make code more semantically correct/less bug-prone, happy to discuss.

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash