Home Original page

actionConfigGetter: allow custom mapping from object to rest.Config by joelanford · Pull Request #317 · operator-framework/helm-operator-plugins

@joelanford

This was referenced

Apr 10, 2024

@joelanford 

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

@codecov-commenter

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.69%. Comparing base (08ab7fb) to head (5a44fe1).
Report is 13 commits behind head on main.

Files Patch % Lines
pkg/client/actionconfig.go 74.35% 7 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   85.06%   85.69%   +0.62%     
==========================================
  Files          19       19              
  Lines        1346     1510     +164     
==========================================
+ Hits         1145     1294     +149     
- Misses        125      139      +14     
- Partials       76       77       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@porridge

FTR, I cherry-picked this change to what stackrox operator uses and ran our e2e tests in a loop to see if this would provoke increased memory usage like it did before #198 but found no adverse effects.

With this change:

ocp
gke

Without this change:

ocp-baseline
gke-baseline

varshaprasad96

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one question.

varshaprasad96

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm