reconciler: fix deletion wait and updater retry logic by joelanford · Pull Request #380 · operator-framework/helm-operator-plugins
@joelanford Would this also need to go into operator-sdk directly as well?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
@acornett21 The code bases are similar, but I can't remember if we have the same updater and wait for deletion logic there.
@joelanford ahh okay, I assumed this issue was coming from an operator, but now I see that stackrox has a direct dependencies on this lib. Just wanted to make sure we cover the bases.
Codecov Report
❌ Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.67%. Comparing base (08ab7fb) to head (175bc01).
⚠️ Report is 139 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/reconciler/internal/updater/updater.go | 78.94% | 2 Missing and 2 partials ⚠️ |
❗ There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (175bc01). Click for more details.
Additional details and impacted files
@@ Coverage Diff @@ ## main #380 +/- ## ========================================== - Coverage 85.06% 79.67% -5.40% ========================================== Files 19 31 +12 Lines 1346 1958 +612 ========================================== + Hits 1145 1560 +415 - Misses 125 310 +185 - Partials 76 88 +12
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters