fix: stop thread pools when an error occurs during startup by lion7 · Pull Request #3107 · operator-framework/java-operator-sdk
Fixes #3099
Tested by running with a locally built snapshot, it fixed the issue.
@lion7 thank you for the PR. The tests unfortunatelly fail, could you pls take a look, in case I can check too a bit later.
@csviri I altered the order a bit so the controllerManager is stopped before the executor, so the graceful shutdown keeps working properly.
I added a unit test per your suggestion
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Signed-off-by: Gerard de Leeuw <gdeleeuw@leeuwit.nl>
Signed-off-by: Gerard de Leeuw <gdeleeuw@leeuwit.nl>
The CI failures are related to some github networking issue (occured also before), I will re-run it bit later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters