Home Original page

:seedling: remove 'function' from function defs in bash scripts by perdasilva · Pull Request #1559 · operator-framework/operator-controller

@perdasilva

Description

Seems it's poor bash form to use the function keyword when defining functions. This PR cleans up our bash scripts in this regard.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

@netlify

gavinmbell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great
LGTM
obama_lgtm

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (5b5ccab) to head (9a2cdc9).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1559   +/-   ##
=======================================
  Coverage   74.25%   74.25%           
=======================================
  Files          42       42           
  Lines        3329     3329           
=======================================
  Hits         2472     2472           
  Misses        676      676           
  Partials      181      181
Flag Coverage Δ
e2e 52.02% <ø> (-0.10%) ⬇️
unit 56.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

azych

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

camilamacedo86

@camilamacedo86