Home Original page

🌱 catalogd: remove unused or unnecessary code by joelanford · Pull Request #1637 · operator-framework/operator-controller

@joelanford

Description

I found some dead code (k8sutil) and a copy of a controller-runtime Server implementation that we implemented, contributed to controller-runtime, and then forgot to switch to once there was a controller-runtime release that included it.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford 

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

@netlify

@codecov

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.35%. Comparing base (96972f0) to head (f437909).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
catalogd/internal/serverutil/serverutil.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
+ Coverage   66.76%   67.35%   +0.59%     
==========================================
  Files          57       55       -2     
  Lines        4600     4555      -45     
==========================================
- Hits         3071     3068       -3     
+ Misses       1303     1261      -42     
  Partials      226      226
Flag Coverage Δ
e2e 53.08% <ø> (ø)
unit 54.18% <0.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

camilamacedo86

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm