Home Original page

✨remove ForceSemverUpgradeConstraints feature gate and implementation by joelanford · Pull Request #1638 · operator-framework/operator-controller

@joelanford

Description

Closes #1615

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@netlify

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (96972f0) to head (cfb2c7b).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   66.76%   66.78%   +0.02%     
==========================================
  Files          57       57              
  Lines        4600     4585      -15     
==========================================
- Hits         3071     3062       -9     
+ Misses       1303     1299       -4     
+ Partials      226      224       -2
Flag Coverage Δ
e2e 53.37% <100.00%> (+0.28%) ⬆️
unit 53.67% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

camilamacedo86

}

successorsPredicate, err := successors(installedBundle, channels...)
successorsPredicate, err := legacySuccessor(installedBundle, channels...)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joelanford

Any reason why we should not remove the unused funcs raised by the lint?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! Pushed an amended commit to fix.

@joelanford 

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

camilamacedo86

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm