Home Original page

:bug: Fix default catalog installation in install script by perdasilva · Pull Request #1680 · operator-framework/operator-controller

@perdasilva

Description

The install script expects default-catalog.yaml to be present in the filesystem. But, it references an url. So, we remove the -f check and kubectl apply the url directly.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

@netlify

camilamacedo86

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

joelanford

LalatenduMohanty

LalatenduMohanty

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (e77c53c) to head (427a7cd).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   67.50%   67.48%   -0.03%     
==========================================
  Files          57       57              
  Lines        4632     4632              
==========================================
- Hits         3127     3126       -1     
- Misses       1278     1279       +1     
  Partials      227      227
Flag Coverage Δ
e2e 53.40% <ø> (ø)
unit 54.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LalatenduMohanty

@camilamacedo86

This comment was marked as off-topic.