🌱 proposing github-->prow reviewer/approver mapping by grokspawn · Pull Request #1894 · operator-framework/operator-controller
Description
Contributes to
- repos will need migration of GH CODEOWNERS files to prow OWNERS / OWNERS_ALIAS files community#107
- (RH) prow config should be used to enforce review/approver status by label community#108
- (RH) no test jobs should need to be configured community#109
- (RH) repos should require 2 labels: approve / lgtm to merge community#110
- (RH) prow should accept review approval as an lgtm (or approve?) community#111
- merge queues will need to be turned off in these repos since prow handles merging community#112
- repos need to have mandatory CI requirements turned off (since they would be independent of prow, and could drift away from that config) community#113
- (RH) branch protection needs to be turned on for the master/main branches in prow so that it requires pass of the same CI jobs community#114
This expands the existing CODEOWNERS file to prow's OWNERS/OWNER_ALIASES files in order to be able to support our contribution ladder.
This will work with openshift/release#63229 to inform automated merge control.
Methodology was, in general...
for approvers:
- expand the existing group
for reviewers: - to make a quick sweep of the operator-framework member list and try to grab folks I felt confident could be considered maintainers
NOTE: There is special attention and OWNERS* files in ./docs, where @michaelryanpeter is the only approver and all other role-holders are identified as reviewers.
!! THESE ROLES SHOULD NOT BE CONSIDERED AUTHORITATIVE/FINAL !!
If your name is listed against a role that you do not feel in good conscience you can fulfill, please let me know by review comment or slack messaging.
If your name is not listed and you feel it should be, please let me know by review comment or slack messaging, including which role you feel fits.
If anything requires further consensus, we will discuss during the weekly OLM Community and Issue Triage Meeting.
Reviewer Checklist
- API Go Documentation
- Tests: Unit Tests (and E2E Tests, if appropriate)
- Comprehensive Commit Messages
- Links to related GitHub Issue(s)