feat(Login): use children for loginmainfooterlinksitem by kmcfaul · Pull Request #10107 · patternfly/patternfly-react
What: Closes #10100
Removes inner structure of LoginMainFooterLinksItem and updates examples to pass buttons directly.
@mcoker There's a pf-v5-svg class that core uses to square up the svg icons that I included here, otherwise the icons are a bit larger and the buttons look rectangular. This class' prefix didn't seem to get updated to v6 though so I'm unsure if I should just remove it?
@kmcfaul it looks good to me, though there are react-icons for all of the footer icons - should we use those instead? GoogleIcon, GithubIcon, DropboxIcon, FacebookSquareIcon, GitlabIcon
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Though looks like we can swap the hardcoded SVGs with the react-icons equivalents 👍
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a code mod issue for this one?
Waiting for alpha release before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters