feat(Select, dropdown, options menu, contect selector, app launcher): Remove deprecated components by tlabaj · Pull Request #10345

feat(Select, dropdown, options menu, contect selector, app launcher): Remove deprecated components by tlabaj · Pull Request #10345 · patternfly/patternfly-react

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments below. The "Editable rows" deprecated Table demo is also still using the now removed deprecated SelectOption component.

		newValue: string \| SelectOptionObject,
		isPlaceholder: boolean
		newValue: any \| any[]
		// isPlaceholder: boolean

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we intend to add this back in at any point?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric. I did add updates for Editable table to my follow up issue #10365

		<MenuToggle ref={toggleRef} onClick={onToggle} isExpanded={isOpen}>
		{isOpen ? 'Expanded' : 'Collapsed'}
		</MenuToggle>
		)}
		>
		{options}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we'll need to import SelectList and wrap it around {options} here.