Home Original page

fix(Menu toggle): Remove pf-m-action modifier by tlabaj · Pull Request #11096 · patternfly/patternfly-react

Conversation

@tlabaj

What: Closes #11095

This PR does the following:

  • bumps core versions to latest
  • Removed the SplitButtonOptions interface and prop since it is no longer needed because there is no longer a variant. Consumers will now pass items directly to splitButtonItems prop
  • update all demos that are impacted by new API

@patternfly-build

mcoker

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🎃TM!

edonehoo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good!

dlabaj

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React code looks good to me.

kmcfaul

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor example update to get it working, otherwise lgtm. Slider also looks like it's acting fine on the preview.

wise-king-sullyman

evwilkin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kmcfaul

Reviewers

@dlabaj dlabaj dlabaj left review comments

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@evwilkin evwilkin evwilkin approved these changes

@mcoker mcoker mcoker approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

+1 more reviewer

@edonehoo edonehoo edonehoo approved these changes

Reviewers whose approvals may not affect merge requirements