Home Original page

chore(deps): Bump v6 branch to latest core alpha by tlabaj · Pull Request #9774 · patternfly/patternfly-react

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!

couple quick questions:

I see that we are defining the token for blue_100 for example as:

export const _pf_t_color_blue_100 = {
  "name": "--pf-t--color--blue--100",
  "value": "#d9e9ff",
  "var": "var(--pf-t--color--blue--100)"
};
export default _pf_t_color_blue_100;

Will that eventually be renamed and somehow replace the coexisting global variable?:

export const global_palette_blue_100 = {
  "name": "--pf-v5-global--palette--blue-100",
  "value": "#bee1f4",
  "var": "var(--pf-v5-global--palette--blue-100)"
};
export default global_palette_blue_100;

EDIT: this might be exactly what your TODO in the PR description is referring to - so never mind :)

Also, the individual token files look good, but in patternfly_variables.js I see quite a few tokens that have value: undefined such as:

"_pf_t_global_color_nonstatus_orangered_100": {
      "name": "--pf-t--global--color--nonstatus--orangered--100",
      "value": "undefined",
      "values": [
        "--pf-t--color--orangered--200",
        "undefined"
      ]
    },

Is that expected?