Update checksum models by tschelabaumann · Pull Request #102 · paymill/paymill-php
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is not backwards compatible, the new version of the wrapper should be 4.0.0
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. It won't break existing implementations. It removed warnings if index isn't set and extends the range. Maybe I overlooked something, but what makes it not backwards compatible?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the handling implemented on the merchants side. A response != 20000 was nerver valid until now. Valid could be implement as success, which is not the case any more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. 4.0.0 it is.