ci: add PHP 8.5's official release by 0x346e3730 · Pull Request #2006 · php/frankenphp

@0x346e3730

@0x346e3730

@0x346e3730

Would be cool if someone could trigger a build & publish of the 8.5 manually before the next run in 23h30m, so we can start using it today rather that tomorrow :)
Nevermind images for 8.5 just have been published (pointing at RC5)

alexandre-daubois

alexandre-daubois

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also remove the experimental: true setting in the CI for PHP 8.5 🙂

@0x346e3730

henderkes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@0x346e3730

Looks like there is some outage on GitHub's side causing jobs to fail (failing to call github's API and cache)

@henderkes

alexandre-daubois

@dunglas

@alexandre-daubois

@dunglas Ah yes, I wasn't sure if you wanted to make these changes right now like setting 8.5 as the default version everywhere right away. Thanks!

henderkes


variable DEFAULT_PHP_VERSION {
default = "8.4"
default = "8.5"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're keeping the default at 8.4 at static-php-cli for now, because too many extensions aren't yet compatible with 8.5 in their latest stable release

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For SPC it makes sense, but for Docker, as we provide images for all supported versions, we can sync defaults with the official images.

@dunglas @henderkes

Co-authored-by: Marc <m@pyc.ac>

henderkes

@dunglas

@0x346e3730

Thank you all for getting this merged quickly, will allow me to play around with 8.5 this week-end 🫶