feat: always ignore user abort by AlliBalliBaba · Pull Request #2189 · php/frankenphp
Pull request overview
This PR automatically enables ignore_user_abort for worker threads, eliminating the need for users to manually configure this setting via INI or in their worker scripts.
Changes:
- Automatically sets
ignore_user_abortto true for worker threads and restores the original setting for non-worker threads - Adds a test to verify workers continue execution after connection abort
- Removes documentation instructing users to manually call
ignore_user_abort(true)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frankenphp.c | Stores original ignore_user_abort setting and automatically enables it for worker threads |
| worker_test.go | Adds test case verifying worker continues after client connection abort |
| docs/worker.md | Removes manual ignore_user_abort(true) call from documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.