feat: allow to customize EmbeddedAppPath by dunglas · Pull Request #2198 · php/frankenphp
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there no simpler way than hijacking ldflags for this?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the benefit? It's a niche use, and ldflags are designed for that.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's true. We should expose it in build-static.sh though.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already exposed through XCADDY_ARGS.